Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is now possible to set the ELK version in the .env file. #303

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

ffknob
Copy link
Contributor

@ffknob ffknob commented Aug 6, 2018

I found it easier to change the version of the ELK stack this way.

README.md Outdated

### Version

Change the ELK stack version in the _.env_ file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather move that to the customization section. The easiest would be to revert this: 8f5b242

@antoineco
Copy link
Collaborator

Good idea! Fast forward 8 months, I believe we can now assume users should have a recent enough Docker version. @deviantony, concerns?

@deviantony
Copy link
Owner

Sounds good to me, maybe rename TAG to something more explicit.

@ffknob
Copy link
Contributor Author

ffknob commented Aug 7, 2018

How about ELK_TAG instead of TAG?
Or do you think it makes sense to have differente TAG variable to the different Elastic product (ELASTICSEARCH_TAG, LOGSTASH_TAG, KIBANA_TAG, ...) so it will be possible to have different versions for different products...?

@deviantony
Copy link
Owner

deviantony commented Aug 7, 2018

I believe that we should use the same version for each component of the stack, this is the way Elastic wants their stack to be used. I was just thinking to rename it to something else like VERSION as it's more explicit IMO.

Thoughts @antoineco ?

@antoineco
Copy link
Collaborator

I actually liked the original commit by the original author :)
8f5b242
Why not just reverting it?

@deviantony
Copy link
Owner

@antoineco Agree

@antoineco
Copy link
Collaborator

Commit reverted, merging.

@antoineco antoineco merged commit cc2f64b into deviantony:master Aug 14, 2018
antoineco pushed a commit that referenced this pull request Aug 14, 2018
antoineco pushed a commit that referenced this pull request Aug 14, 2018
DanBrown47 pushed a commit to DanBrown47/docker-elk that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants