-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the project for supporting the latest GA version 6.0.0 OSS Edition #196
Conversation
edition with no X-Pack support
Thanks for the PR! The docs still mention that X-Pack options should be explicitly enabled/disabled: https://www.elastic.co/guide/en/x-pack/current/xpack-settings.html. Could you clarify why Kibana and Logstash do not need it anymore? |
Do we really want to use the OSS images without x-pack? I鈥檓 managing security externally, so it doesn鈥檛 bother me. I do wonder if we document how to migrate kinsman indexes. |
...if we /should/ document how... |
It makes sense to use OSS on the |
It seems that only ElasticSearch requires to install the X-Pack plugin and it requires also to mention all the properties for disabling it. For Kibana and Logstash there is no need to install and disable the plugin. You can simply avoid to install the plugin and you don't need to add properties in the configuration files for disabling X-Pack. |
@OpenPj it seems like Elasticsearch also has an |
README.md
Outdated
@@ -1,7 +1,7 @@ | |||
# Docker ELK stack | |||
|
|||
[![Join the chat at https://gitter.im/deviantony/docker-elk](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/deviantony/docker-elk?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) | |||
[![Elastic Stack version](https://img.shields.io/badge/ELK-5.6.3-blue.svg?style=flat)](https://github.com/deviantony/docker-elk/issues/182) | |||
[![Elastic Stack version](https://img.shields.io/badge/ELK-6.0.0-blue.svg?style=flat)](https://github.com/deviantony/docker-elk/issues/182) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 129 also contains a reference to the current version.
elasticsearch/Dockerfile
Outdated
|
||
# Add your elasticsearch plugins setup here | ||
# Example: RUN elasticsearch-plugin install analysis-icu | ||
RUN elasticsearch-plugin install x-pack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you install X-pack just to disable it the config?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because otherwise ElasticSearch returns an exception during the bootstrap and the application can't be started. I sincerely don't know why and it sounds to me just a little bit strange.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because you didn't delete xpack.*
settings, so ES crashes due to unsupported options.
@@ -19,7 +19,8 @@ discovery.type: single-node | |||
## see https://www.elastic.co/guide/en/x-pack/current/xpack-settings.html | |||
## https://www.elastic.co/guide/en/x-pack/current/installing-xpack.html#xpack-enabling | |||
# | |||
xpack.security.enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment, we should get rid of all xpack.*
settings.
Kibana starts now much faster than in v5.x
@OpenPj I pushed a couple of changes and merged |
Release notes:
I have updated the ELK stack using the latest OSS edition but probably it could be useful to have different branches dedicated to the OSS and Enterprise editions.
Starting from this release to disable X-Pack we need to install the plugin and the disable it using properties. For Kibana and Logstash we can remove all the properties.
Hope this helps 馃槃