Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the project for supporting the latest GA version 6.0.0 OSS Edition #196

Merged
merged 6 commits into from
Nov 17, 2017

Conversation

OpenPj
Copy link
Contributor

@OpenPj OpenPj commented Nov 15, 2017

Release notes:

I have updated the ELK stack using the latest OSS edition but probably it could be useful to have different branches dedicated to the OSS and Enterprise editions.

Starting from this release to disable X-Pack we need to install the plugin and the disable it using properties. For Kibana and Logstash we can remove all the properties.

Hope this helps 馃槃

@antoineco antoineco mentioned this pull request Nov 17, 2017
@antoineco
Copy link
Collaborator

Thanks for the PR! The docs still mention that X-Pack options should be explicitly enabled/disabled: https://www.elastic.co/guide/en/x-pack/current/xpack-settings.html. Could you clarify why Kibana and Logstash do not need it anymore?

@josephholsten
Copy link

Do we really want to use the OSS images without x-pack? I鈥檓 managing security externally, so it doesn鈥檛 bother me.

I do wonder if we document how to migrate kinsman indexes.

@josephholsten
Copy link

...if we /should/ document how...

@antoineco
Copy link
Collaborator

It makes sense to use OSS on the master branch if it doesn't include X-Pack (question mark here), especially since we have a dedicated branch for X-Pack.

@OpenPj
Copy link
Contributor Author

OpenPj commented Nov 17, 2017

Thanks for the PR! The docs still mention that X-Pack options should be explicitly enabled/disabled: https://www.elastic.co/guide/en/x-pack/current/xpack-settings.html. Could you clarify why Kibana and Logstash do not need it anymore?

It seems that only ElasticSearch requires to install the X-Pack plugin and it requires also to mention all the properties for disabling it.

For Kibana and Logstash there is no need to install and disable the plugin. You can simply avoid to install the plugin and you don't need to add properties in the configuration files for disabling X-Pack.

@antoineco
Copy link
Collaborator

antoineco commented Nov 17, 2017

@OpenPj it seems like Elasticsearch also has an oss flavour, without X-Pack 馃弳
https://github.com/elastic/elasticsearch-docker/blob/master/Makefile#L16

README.md Outdated
@@ -1,7 +1,7 @@
# Docker ELK stack

[![Join the chat at https://gitter.im/deviantony/docker-elk](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/deviantony/docker-elk?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
[![Elastic Stack version](https://img.shields.io/badge/ELK-5.6.3-blue.svg?style=flat)](https://github.com/deviantony/docker-elk/issues/182)
[![Elastic Stack version](https://img.shields.io/badge/ELK-6.0.0-blue.svg?style=flat)](https://github.com/deviantony/docker-elk/issues/182)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 129 also contains a reference to the current version.


# Add your elasticsearch plugins setup here
# Example: RUN elasticsearch-plugin install analysis-icu
RUN elasticsearch-plugin install x-pack
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you install X-pack just to disable it the config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because otherwise ElasticSearch returns an exception during the bootstrap and the application can't be started. I sincerely don't know why and it sounds to me just a little bit strange.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's because you didn't delete xpack.* settings, so ES crashes due to unsupported options.

@@ -19,7 +19,8 @@ discovery.type: single-node
## see https://www.elastic.co/guide/en/x-pack/current/xpack-settings.html
## https://www.elastic.co/guide/en/x-pack/current/installing-xpack.html#xpack-enabling
#
xpack.security.enabled: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment, we should get rid of all xpack.* settings.

@antoineco
Copy link
Collaborator

@OpenPj I pushed a couple of changes and merged master in your fork. Good to go!

@antoineco antoineco merged commit f374eff into deviantony:master Nov 17, 2017
antoineco pushed a commit that referenced this pull request Nov 17, 2017
antoineco pushed a commit that referenced this pull request Nov 17, 2017
inputfalken pushed a commit to inputfalken/docker-elk that referenced this pull request Nov 17, 2017
antoineco pushed a commit that referenced this pull request Nov 17, 2017
antoineco pushed a commit that referenced this pull request Nov 17, 2017
antoineco pushed a commit that referenced this pull request Nov 17, 2017
antoineco pushed a commit that referenced this pull request Nov 17, 2017
antoineco pushed a commit that referenced this pull request Jan 2, 2018
DanBrown47 pushed a commit to DanBrown47/docker-elk that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants