-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 5.4 #120
Update to 5.4 #120
Conversation
Includes required change for logstash config and disables the new machine learning functionality in x-pack by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'll merge it after my 2 comments are addressed. Also beware that you committed with an anonymous Github user (not sure if that was intentional).
logstash/config/logstash.yml
Outdated
## The path to the Logstash config for the main pipeline. | ||
## see https://www.elastic.co/guide/en/logstash/current/logstash-settings-file.html | ||
# | ||
path.config: /usr/share/logstash/pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already defaults to /usr/share/logstash/pipeline
so this should be removed. See https://www.elastic.co/guide/en/logstash/current/dir-layout.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my thought as well but running it you get
logstash_1 | Sending Logstash's logs to /usr/share/logstash/logs which is now configured via log4j2.properties
logstash_1 | [2017-05-08T15:02:53,112][INFO ][logstash.setting.writabledirectory] Creating directory {:setting=>"path.queue", :path=>"/usr/share/logstash/data/queue"}
logstash_1 | usage:
logstash_1 | bin/logstash -f CONFIG_PATH [-t] [-r] [] [-w COUNT] [-l LOG]
logstash_1 | bin/logstash -e CONFIG_STR [-t] [--log.level fatal|error|warn|info|debug|trace] [-w COUNT] [-l LOG]
logstash_1 | bin/logstash -i SHELL [--log.level fatal|error|warn|info|debug|trace]
logstash_1 | bin/logstash -V [--log.level fatal|error|warn|info|debug|trace]
logstash_1 | bin/logstash --help
logstash_1 | ERROR: No configuration file was specified. Perhaps you forgot to provide the '-f yourlogstash.conf' flag?
dockerelk_logstash_1 exited with code 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry! It was added as part of elastic/logstash-docker@303eafe, you're right. Can you just delete the comment and move it right below http.host: "0.0.0.0"
then?
@@ -14,6 +14,7 @@ services: | |||
# https://www.elastic.co/guide/en/x-pack/current/installing-xpack.html#xpack-enabling | |||
xpack.security.enabled: "false" | |||
xpack.monitoring.enabled: "false" | |||
xpack.ml.enabled: "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also be disabled in the kibana.yml
file for completeness. See https://www.elastic.co/guide/en/x-pack/current/installing-xpack.html#xpack-enabling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I missed that will get it corrected
- Also reorder so the default config is at the top
Thanks a lot @mtdavidson ! |
No problem thanks for the quick merge :) |
Includes required change for logstash config and disables the new machine learning functionality in x-pack by default.
Includes required change for logstash config and disables the new machine learning functionality in x-pack by default.
Includes required change for logstash config and disables the new machine learning functionality in x-pack by default.
Includes required change for logstash config and disables the new machine learning functionality in x-pack by default.
Includes required change for logstash config and disables the new machine learning functionality in x-pack by default.