Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off linting by default in VS Code for Python #449

Merged

Conversation

brettcannon
Copy link
Contributor

Linting is on by default if you specify the paths to any linters, so the previous settings would turn on all linters.

Also drop linters that don't see much use.

Linting is on by default if you specify the paths to any linters, so the previous settings would turn on **all** linters.

Also drop linters that don't see much use.
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some thoughts!

src/python/install.sh Outdated Show resolved Hide resolved
src/python/devcontainer-feature.json Show resolved Hide resolved
@brettcannon
Copy link
Contributor Author

@samruddhikhandale I updated the PR to only remove settings related to the under-utilized tool support in the Python extension for VS Code and to turn linting off by default so users can choose which linter they want.

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! 🚢

@samruddhikhandale samruddhikhandale merged commit 4b7efeb into devcontainers:main Mar 1, 2023
@brettcannon brettcannon deleted the simplify-python-tools branch March 2, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants