Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made dependency on future python 2 only #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeldin
Copy link

@zeldin zeldin commented May 15, 2024

KiPart has a dependency on the "future" module. Going through the code I found that the only use of this module is two instances of calling future.standard_library.install_aliases(). This function is defined as doing nothing at all on python 3. Thus, the call is only needed on python 2 and it's simple to make it so that it is only called on python 2, making the dependency not needed on python 3.

Why is this important? Well, with python 2 having become EOL, distributions are starting to remove python 2, and also the future module (see e.g. https://bugs.gentoo.org/888271). Thus, requiring the module in order to install for python 3 makes packaging difficult (or at least awkward).

Note that uses of __future__ (with the underscores) are not affected by this at all, since that is a builtin "module" and guaranteed to be available in every Python installation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant