Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getMetadataValues for projects #9618

Merged
merged 16 commits into from
Jul 10, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jul 8, 2024

Ticket

ET-226

Description

Add getMetadataValues endpoints which fetches all unique metadata values for a given key in a given project. This only applies to metadata values that are string typed.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 8, 2024
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 5e6cdbc
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668eaaedee32fc0008facceb
😎 Deploy Preview https://deploy-preview-9618--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.89%. Comparing base (0a57cde) to head (5e6cdbc).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9618      +/-   ##
==========================================
- Coverage   52.91%   52.89%   -0.03%     
==========================================
  Files        1255     1255              
  Lines      153086   153105      +19     
  Branches     3230     3229       -1     
==========================================
- Hits        81004    80978      -26     
- Misses      71931    71976      +45     
  Partials      151      151              
Flag Coverage Δ
backend 44.01% <84.21%> (-0.07%) ⬇️
harness 72.76% <ø> (ø)
web 51.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/api_project.go 36.83% <84.21%> (+1.45%) ⬆️

... and 8 files with indirect coverage changes

@AmanuelAaron AmanuelAaron marked this pull request as ready for review July 8, 2024 19:36
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner July 8, 2024 19:36
Copy link
Contributor

@corban-beaird corban-beaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One last small nit, but it's non-blocking

Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

web changes ok!

@AmanuelAaron AmanuelAaron merged commit d257b89 into main Jul 10, 2024
85 of 98 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/get-metadata-values branch July 10, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants