Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata filtering to SearchRuns #9611

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jul 5, 2024

Ticket

ET-50

Description

Add the ability to filter base off of arbitrary metadata in SearchRuns endpoint. This should work similarly to how hyperparameters are filtered currently.

Test Plan

Written tests should pass.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit d99b257
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668ebc0a147af10008832b73
😎 Deploy Preview https://deploy-preview-9611--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cla-bot cla-bot bot added the cla-signed label Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 58.75000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 52.89%. Comparing base (0a57cde) to head (d99b257).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9611      +/-   ##
==========================================
- Coverage   52.91%   52.89%   -0.03%     
==========================================
  Files        1255     1255              
  Lines      153086   153166      +80     
  Branches     3230     3229       -1     
==========================================
+ Hits        81004    81010       +6     
- Misses      71931    72005      +74     
  Partials      151      151              
Flag Coverage Δ
backend 44.02% <58.22%> (-0.06%) ⬇️
harness 72.76% <ø> (ø)
web 51.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/ioTypes.ts 90.90% <100.00%> (+0.02%) ⬆️
master/internal/experiment_filter.go 86.53% <58.22%> (-5.25%) ⬇️

... and 8 files with indirect coverage changes

@AmanuelAaron AmanuelAaron marked this pull request as ready for review July 9, 2024 15:41
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner July 9, 2024 15:41
@AmanuelAaron AmanuelAaron requested review from kkunapuli, johnkim-det and jesse-amano-hpe and removed request for kkunapuli July 9, 2024 15:41
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmanuelAaron AmanuelAaron requested a review from a team as a code owner July 10, 2024 16:51
@AmanuelAaron AmanuelAaron changed the title feat: add metadata filtering feat: add metadata filtering to SearchRuns Jul 10, 2024
Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit/question: does the location need to be named RUN_METADATA instead of just METADATA? Looks like we specify for HYPERPARAMETERS/RUN_HYPERPARAMETERS but not for VALIDATIONS, TRAINING, or CUSTOM_METRIC. FWIW it looks like we said METADATA was fine in grooming.

either way, LocationType changes in web LGTM

@AmanuelAaron AmanuelAaron merged commit 4eeb4db into main Jul 15, 2024
81 of 95 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/metadata-filter branch July 15, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants