Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search roles #372

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Search roles #372

merged 2 commits into from
Mar 6, 2024

Conversation

slavikm
Copy link
Member

@slavikm slavikm commented Mar 5, 2024

Description

Search roles based on given filter parameters

Must

  • Tests
  • Documentation (if applicable)

@slavikm slavikm requested a review from aviadl March 5, 2024 23:06
Copy link

github-actions bot commented Mar 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  descope/management
  common.py
  role.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@guyp-descope guyp-descope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one question: do we want to include the roles ids in the response?

@slavikm
Copy link
Member Author

slavikm commented Mar 6, 2024

Looks good, one question: do we want to include the roles ids in the response?

I don't believe we expose the role IDs externally in any of the APIs. Just the role names...

@slavikm slavikm merged commit 1860318 into main Mar 6, 2024
19 checks passed
@slavikm slavikm deleted the feat/search-roles branch March 6, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants