Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flask): adding flask decorators as a package extra #291

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

omercnet
Copy link
Member

@omercnet omercnet commented Sep 18, 2023

Related Issues

Fixes https://github.com/descope/etc/issues/2539

Description

Making flask an extra package of descope python-sdk
Extra means it is not installed by default, and only when adding the extra flag it will also install Flask dependencies that are needed.

  • Adjusted the sample scripts to work with the package itself
  • Added typing annotations
  • Reduced test coverage of the new code
  • Also added vscode settings and recommended extensions for ease development
  • Removed tox from pre-commit as it's a huge overhead for every commit, devs should test locally before committing, and tests still run in CI still.

@github-actions
Copy link

github-actions bot commented Sep 18, 2023

Coverage report

The coverage rate went from 98.12% to 98.12% ⬇️

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@omercnet omercnet requested review from guyp-descope and removed request for slavikm, orius123, tomski747, aviadl and newman-dani September 21, 2023 11:55
@omercnet omercnet enabled auto-merge (squash) September 21, 2023 12:24
@omercnet omercnet merged commit 6d4d6e0 into main Sep 21, 2023
19 checks passed
@omercnet omercnet deleted the feat/flask_extra branch September 21, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants