Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor for typing, proper version checks, and more #283

Merged
merged 33 commits into from
Sep 18, 2023
Merged

Conversation

omercnet
Copy link
Member

@omercnet omercnet commented Sep 6, 2023

Related Issues

Fixes https://github.com/descope/etc/issues/4039

Description

Expanding support for python 3.11
Adding typing annotations everywhere, fix bugs that it uncovered
Use tox for automated testing
Add tests for all platforms
limiting support for 3.7 to test only

Must

  • Tests

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Coverage report

Note

Coverage data for the default branch was not found.
This usually happens when the action has not run on the default
branch yet, for example right after deploying it into the workflows.

The coverage rate is 98.11%.

88.88% of new lines are covered.

Diff Coverage details (click to unfold)

descope/authmethod/oauth.py

100% of new lines are covered (100% of the complete file).

descope/authmethod/otp.py

100% of new lines are covered (100% of the complete file).

descope/management/access_key.py

100% of new lines are covered (100% of the complete file).

descope/common.py

100% of new lines are covered (100% of the complete file).

descope/management/tenant.py

100% of new lines are covered (100% of the complete file).

descope/management/audit.py

50% of new lines are covered (69.44% of the complete file).
Missing lines: 90, 92

descope/authmethod/webauthn.py

100% of new lines are covered (100% of the complete file).

descope/management/role.py

100% of new lines are covered (100% of the complete file).

descope/management/sso_settings.py

71.42% of new lines are covered (95.74% of the complete file).
Missing lines: 206, 222

descope/auth.py

80% of new lines are covered (95.86% of the complete file).
Missing lines: 16, 17, 50, 51, 634

descope/authmethod/magiclink.py

100% of new lines are covered (100% of the complete file).

descope/authmethod/totp.py

100% of new lines are covered (100% of the complete file).

descope/management/group.py

100% of new lines are covered (100% of the complete file).

descope/authmethod/enchantedlink.py

100% of new lines are covered (100% of the complete file).

descope/management/permission.py

100% of new lines are covered (100% of the complete file).

descope/authmethod/password.py

100% of new lines are covered (100% of the complete file).

descope/exceptions.py

100% of new lines are covered (100% of the complete file).

descope/management/user.py

100% of new lines are covered (100% of the complete file).

descope/descope_client.py

100% of new lines are covered (97.45% of the complete file).

descope/management/common.py

100% of new lines are covered (100% of the complete file).

descope/authmethod/saml.py

100% of new lines are covered (100% of the complete file).

descope/auth.py Show resolved Hide resolved
descope/auth.py Outdated Show resolved Hide resolved
descope/auth.py Outdated Show resolved Hide resolved
@omercnet omercnet changed the title fix: typing and broader version checks chore: refactor for typing, proper version checks, and more Sep 13, 2023
@omercnet omercnet enabled auto-merge (squash) September 13, 2023 13:17
@omercnet omercnet merged commit 7e54658 into main Sep 18, 2023
19 checks passed
@omercnet omercnet deleted the fix/types branch September 18, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants