fix: Change persist-tokens hook to always add token (if exists) t http requests #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, @nirgur please review as well. |
|
I'm not sure I fully understand this change |
Would love to :) |
|
closing in favor to another solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes https://github.com/descope/etc/issues/5319
Description
change web-js-sdk to always send the token if it exists
like mentioned in the issue, someone may rely on the fact that the token is also in the local storage
so we should document it clearly in RN that this may break existing code that relies on the previous buggy behavior (I don't want to bump major for this bug though)