Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest supported source version #92

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

thyming
Copy link
Contributor

@thyming thyming commented May 20, 2019

Closes #90.

I investigated changing the build JDK for the processor to JDK 11, but there's a bug I'm hitting in the compiler that's preventing upgrade.

@codecov-io
Copy link

Codecov Report

Merging #92 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
+ Coverage     90.18%   90.19%   +<.01%     
- Complexity      848      849       +1     
============================================
  Files            56       56              
  Lines          2925     2926       +1     
  Branches        135      135              
============================================
+ Hits           2638     2639       +1     
  Misses          226      226              
  Partials         61       61
Impacted Files Coverage Δ Complexity Δ
...java/org/derive4j/processor/DerivingProcessor.java 71.31% <100%> (+0.23%) 33 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 189599c...765ad7b. Read the comment docs.

@jbgi jbgi self-requested a review June 5, 2019 14:37
@jbgi jbgi merged commit f73e8c9 into derive4j:master Jun 5, 2019
@jbgi
Copy link
Member

jbgi commented Jun 5, 2019

Thanks! And sorry for late review, somehow missed github notif for your PR.
Will release soon with the changes.

@thyming thyming deleted the support-java-11 branch June 5, 2019 14:46
@jbgi jbgi added this to the 1.1.1 milestone Jun 22, 2019
@jbgi
Copy link
Member

jbgi commented Jul 4, 2019

@thyming 1.1.1 should be on its way to maven central (built with jdk12, targeting 1.8). Thanks for PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support Java 11
3 participants