Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated class names for adt class names ending in y #86

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Fix generated class names for adt class names ending in y #86

merged 1 commit into from
Mar 19, 2018

Conversation

pkoenig10
Copy link
Contributor

The substitution of "y" with "ies" should only take place if the letter preceding the "y" is a consonant. There are no words that end in "iy" or "uy".

https://en.oxforddictionaries.com/spelling/plurals-of-nouns

@jbgi
Copy link
Member

jbgi commented Mar 19, 2018

Thanks!
Can your run ./gradlew spotlessApply and amend your commit?

@jbgi jbgi added this to the 0.12.4 milestone Mar 19, 2018
@derive4j derive4j deleted a comment from codecov-io Mar 19, 2018
@jbgi jbgi merged commit d8c4ce9 into derive4j:master Mar 19, 2018
@jbgi
Copy link
Member

jbgi commented Mar 19, 2018

Fix available in 0.12.4 just released.

@pkoenig10 pkoenig10 deleted the plural branch March 19, 2018 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants