Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auto formating to smooth contributions reviews #83

Closed
wants to merge 1 commit into from

Conversation

jbgi
Copy link
Member

@jbgi jbgi commented Mar 13, 2018

  • update dependencies

@derive4j derive4j deleted a comment from codecov-io Mar 13, 2018
If((cond, then, otherwise) -> eval(cond)
? eval(then)
: eval(otherwise));
return Terms.caseOf(term).Zero(__ -> __.coerce(0)).Succ((t, __) -> __.coerce(eval(t) + 1))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pretty....

Copy link
Contributor

@gneuvill gneuvill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatter is a bit harsh on the "pattern matching" syntax. Would that be tunable ?

@jbgi
Copy link
Member Author

jbgi commented Mar 13, 2018

I'm going to try a custom eclipse formatter conf and see if it helps

@derive4j derive4j deleted a comment from codecov-io Mar 17, 2018
@jbgi jbgi closed this Mar 17, 2018
@jbgi jbgi deleted the format-update branch March 19, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants