Clarify that ADT are not only sum types #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbgi
changed the title
Zoybean
reviewed
Jan 16, 2018
README.md
Outdated
| An example being worth a thousand words... | ||
| A good deal of what is commonly available in better languages like Haskell: structural pattern matching, laziness, lenses and prisms. | ||
|
|
||
| Algebraic data types come in two flavours, product types and sum types. This readme focus on sum types because it is the more interesting case; product types being the well known common case in java. But Derive4J handles product types in exactly the same fashion (ie. through a visitor interface with a single abstract method). |
There was a problem hiding this comment.
It's good, though the new paragraph seems out of place under the list of features. Perhaps if it were closer to the previous mention of ADTs, or if ADTs were mentioned in the feature list, eg "[...] structural pattern matching (and/with/on) Algebraic Data Types, [...]"
There was a problem hiding this comment.
updated intro paragraph. tell me if further remarks.
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
========================================
Coverage 5.59% 5.59%
Complexity 39 39
========================================
Files 55 55
Lines 2610 2610
Branches 143 143
========================================
Hits 146 146
Misses 2459 2459
Partials 5 5Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.