Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal better with wildcards #80

Closed
wants to merge 6 commits into from
Closed

Deal better with wildcards #80

wants to merge 6 commits into from

Conversation

gneuvill
Copy link
Contributor

No description provided.

gneuvill and others added 5 commits February 3, 2017 17:31
Of course, there is still https://dilbert.com/strip/2001-10-25 , but anyway `com.sun.tools.javac` is definitely not thread safe so using parallel streams in annotation processors doesn't seem like a good idea...
@jbgi jbgi self-requested a review January 16, 2018 12:08
@derive4j derive4j deleted a comment from codecov-io Mar 17, 2018
@jbgi
Copy link
Member

jbgi commented Mar 17, 2018

The fix for GADT TC derivation is welcomed, thanks!

#78 does not appear to be fixed by this PR (tried with your example and a simpler one, with the List). But I don't think it can be fixed in Java for the general case.

@jbgi
Copy link
Member

jbgi commented Mar 17, 2018

rebased in #84

@jbgi jbgi closed this Mar 17, 2018
@gneuvill
Copy link
Contributor Author

#78 does not appear to be fixed by this PR

Probably because it must be used in combination with : derive4j/derive4j-fj#5 ?

@gneuvill gneuvill reopened this Mar 17, 2018
@jbgi
Copy link
Member

jbgi commented Mar 17, 2018

@gneuvill I see, I will have a look to that PR now. I merged the related commit in #84 anyway.

@jbgi
Copy link
Member

jbgi commented Mar 18, 2018

merged via #84

@jbgi jbgi closed this Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants