Add guava flavour (needs test!) #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! thanks! |
|
Also it looks like your commit is associated with another github account of yours (@anon789) are you ok with that? |
|
No idea what that other account is, I don't care. |
|
Hang on I'll add a test |
|
jenkins problem |
|
@h908714124 ah yeah forgot about that: it just need a bsd header. you can add it via "./gradlew licenseFormatTest". |
|
didn't help |
|
ok... sorry forgot about the other file in src/main... that is taken care of by "./gradlew licenseFormatMain". |
|
yeah!! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would have loved to add a test but wasn't sure where to put it