Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vavr flavour #71

Closed
jbgi opened this issue May 16, 2017 · 4 comments
Closed

Add Vavr flavour #71

jbgi opened this issue May 16, 2017 · 4 comments
Labels
enhancement
Milestone
0.12.3

Comments

@jbgi
Copy link
Member

jbgi commented May 16, 2017

No description provided.

@talios
Copy link
Contributor

talios commented Jun 1, 2017

+1000 for this :)

@jbgi
Copy link
Member Author

jbgi commented Jun 2, 2017

@talios would like to implement this?
There is two class to modify:
First add Vavr flavour in https://github.com/derive4j/derive4j/blob/master/annotation/src/main/java/org/derive4j/Flavour.java
Then do a ./gradlew build
Then make the DeriveUtilsImpl class compile, by adding the vavr case in:

derive4j/processor/src/main/java/org/derive4j/processor/DeriveUtilsImpl.java

Line 167 in 3b6d687

function0Model = Flavours.cases()

@talios
Copy link
Contributor

talios commented Jun 6, 2017

Wish I'd seen this on the weekend ( long weekend holiday ) - will take a stab at it tonight!

talios added a commit to talios/derive4j that referenced this issue Jun 6, 2017
@talios
Adds io.vavr support, fixing derive4j#71
02bdd2a
talios pushed a commit to talios/derive4j that referenced this issue Jun 6, 2017
Bump version number for io.vavr support. derive4j#71
734637d
jbgi pushed a commit that referenced this issue Jun 6, 2017
@talios @jbgi
Adds io.vavr support, fixing #71
e7c8046
jbgi pushed a commit that referenced this issue Jun 6, 2017
@jbgi
Bump version number for io.vavr support. #71
9a8ee06
@jbgi
Copy link
Member Author

jbgi commented Jun 6, 2017

Fixed via e7c8046

@jbgi jbgi closed this as completed Jun 6, 2017
@jbgi jbgi added this to the 0.12.3 milestone Jun 6, 2017
@jabrena jabrena mentioned this issue Dec 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.12.3
Development

No branches or pull requests
2 participants
@talios @jbgi