set authorized_keys directory so its actually used

[rndmh3ro]

Before this commit, you could specify a authorized_keys directory, but it would only be created, not actually used, unless you specified twice:

accounts::users:
  user:
    authorized_keys_file: '/etc/ssh/authorized_keys_user'
    comment: "foo Bar"
    ssh_keys:
      'user':
        target: "/etc/ssh/authorized_keys_user"
        type: "ssh-rsa"
        key: "asdjsjgiov"

I don't know why the test "supply custom path to authorized_keys file outside of home dir" doesn't catch this, but I guess, because the target-option for ssh_authorized_keys is missing and the test looks for the key in the home-directory, where its created.
I can't test it myself, either.

Anyway, now it works like this:

accounts::users:
  user:
    authorized_keys_file: '/etc/ssh/authorized_keys_user'
    comment: "foo Bar"
    ssh_keys:
      'user':
        type: "ssh-rsa"
        key: "asdjsjgiov"

Additionally a needed dependency was set so the authorized_keys-file gets created before trying to insert keys into it.

[deric]

Have a look at the Travis build logs. It seems to introduce a cycle on some Puppet versions:

       dependency cycles found: (File[/home/myuser/.ssh/authorized_keys] => Ssh_authorized_key[myawesomefirstkey] => File[/home/myuser/.ssh/authorized_keys])
     # ./spec/classes/init_spec.rb:13:in `block (2 levels) in <top (required)>'

Moreover for Puppet 4 compatibility the word type should be quoted.

 Use of reserved word: type, must be quoted if intended to be a String 

[rndmh3ro]

Strange, this did not happen for me locally.
I'll check it tomorrow, and I'll also add back the quotes around type!

[deric]

Thanks!

[rndmh3ro]

You're welcome!

PS: Could you release a new version on the forge?

[deric]

Sure. v1.5.1 has been released.