Feature: allow to use cleartext passwords #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generating a hash salt when the user is created - Adding a custom fact to retrieve the created hash on later runs - Possibility to override the salt explicitly - Changing spec tests accordingly
|
Cool, looks good. Thanks a lot Oliver! |
|
Hi Tomas, any plans on when 1.5 will be released? Cheers, |
|
Hopefully soon, with the acceptance test I'm more confident that I'm not breaking any existing features. I guess today (at most tomorrow) I should release it. |
deric
added a commit
that referenced
this pull request
Nov 23, 2016
|
@poikilotherm I'd like to merge this refactoring if possible. I've tried to simplify the code a bit and resolve long-term issues. According to test it looks good but still I'd like to verify it :) |
|
@poikilotherm v1.5.0 released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I manage local users with this puppet module. Recently I had the need to use cleartext passwords for such a user, as the password needed to be inserted into Samba users, too. As Samba does not use
/etc/shadowpasswords, I had to extend the module.I would be glad if this would be merged into this great module.
Thanks,
Oliver