Add user type parameter 'purge_ssh_keys' to the account::user class. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, sometime I hate the Types Doc - no hint this feature was first added with Puppet 3.6... So most Travis Runs fail because of "invalid parameter", the rest is failing because of things I IMHO didn't cause. Maybe I should add a puppet version switch and put a file deletion before ssh_keys for puppet < 3.6? What do you think? |
|
Cool, thanks. I guess we should either display a warning for |
deric
added a commit
that referenced
this pull request
Jul 2, 2015
…_keys_option Add user type parameter 'purge_ssh_keys' to the account::user class.
deric
added a commit
that referenced
this pull request
Jul 2, 2015
|
Thanks for merging and modification. Could you release a new forge version, too? Thanks in advance. :) |
|
Sure, tagged as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not specify a Rspec test, as I think the validation does not need to be tested and the correctness of purge_ssh_keys in user should not be validated here (already done in https://github.com/puppetlabs/puppet/blob/master/spec/unit/type/user_spec.rb)
Would be glad if you could merge this.
If you would like me to add some more doc / ..., please respond here. :)