Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to manage group members of a group #25

Closed
wants to merge 1 commit into from

Conversation

hhenkel
Copy link
Contributor

@hhenkel hhenkel commented Apr 28, 2015

We're using onyxpoint/gpasswd to enable the management of group members
(for example ad users as members of a local group). The
onyxpoint/gpasswd module does that by overwriting parts of the group
provider. Changes to user.pp was necessary so that members of the
primary group of a user could be managed as well.

We're using onyxpoint/gpasswd to enable the management of group members
(for example ad users as members of a local group). The
onyxpoint/gpasswd module does that by overwriting parts of the group
provider. Changes to user.pp was necessary so that members of the
primary group of a user could be managed as well.
@deric
Copy link
Owner

deric commented Apr 29, 2015

That's interesting, I was just trying to resolve an issue with existing groups on servers. This might fix that.

@@ -6,6 +6,7 @@
$primary_group = "${title}", # intentionally, workaround for: https://tickets.puppetlabs.com/browse/PUP-4332
$comment = "${title}", # see https://github.com/deric/puppet-accounts/pull/11
$username = "${title}",# for more details
$group_members = undef,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite confusing. Do we really want to add members into user's primary group? And how do we synchronize the data?

  class {'accounts':
    groups => {
      'users' => {
        'members' => ['john'],
      },
    },
    users => { 'john' => {
      'groups'  => ['users'],
      'group_members' = ['snow']
    }}
  }

In this case user John should be a member of group users. That's clear, even specified twice (once in user's definition and other in group definition). Then we have undefined user snow, which should be created? or it should throw an error? Do I have to specify user itself in his primary group?

Could you write some tests for this functionality? What if we want to remove users from some group?

We have multiple attributes concerning groups, primary_group, gid, groups and now group_members. It's starting to be quite confusing :(

@hhenkel
Copy link
Contributor Author

hhenkel commented May 21, 2015

Sorry, I'm currently busy with other things, will come back to this at a later time.

@deric
Copy link
Owner

deric commented Mar 5, 2016

This seems to be tracked as a bug in Puppet.

@deric
Copy link
Owner

deric commented Mar 5, 2016

I'm closing this in favor of 62fd7ab.

@deric deric closed this Mar 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants