Skip to content

Commit

Permalink
[FLINK-14859][runtime] Remove wrong checkState
Browse files Browse the repository at this point in the history
A slot that is assigned to an execution may be unreleased even if a deployment
is outdated. However, this is safe, because the execution is responsible for
releasing the slot.

This closes apache#10351.
  • Loading branch information
GJL committed Nov 28, 2019
1 parent 9c9ac52 commit 3044753
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -440,12 +440,6 @@ private BiFunction<Object, Throwable, Void> deployOrHandleError(final Deployment

return (ignored, throwable) -> {
if (executionVertexVersioner.isModified(requiredVertexVersion)) {
final boolean slotAlive = deploymentHandle
.getLogicalSlot()
.map(LogicalSlot::isAlive)
.orElse(false);
checkState(!slotAlive, "Expected slot to be released");

log.debug("Refusing to deploy execution vertex {} because this deployment was " +
"superseded by another deployment", executionVertexId);
return null;
Expand Down

0 comments on commit 3044753

Please sign in to comment.