feat: Notification 도메인 설계 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CChuYong
reviewed
Jun 14, 2024
|
|
||
| interface NotificationGateway { | ||
| fun save(notification: Notification): Notification | ||
| fun getRecentNotification(memberId: String): Notification? |
There was a problem hiding this comment.
요거 nullable이면 find, not null이면 get 어떠신가용
There was a problem hiding this comment.
@CChuYong 넴 좋아용!!!!!!!!!!!
CChuYong
reviewed
Jun 14, 2024
| val type: NotificationType, | ||
|
|
||
| @Schema(description = "읽기 여부") | ||
| val float: Boolean, |
nullable -> find response 필드명 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 기능
🔎 기타
Close #92