SharedGraphics: Make Rect::shatter() return a Vector<Rect, 4>.

We know that shatter() will never return more than four rects, so we can use vector inline capacity to always avoid heap allocation here.
deoxxa · May 27, 2019 · 4fb2e5d · 4fb2e5d
1 parent 3873c51
commit 4fb2e5d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/SharedGraphics/Rect.cpp b/SharedGraphics/Rect.cpp
@@ -34,11 +34,11 @@ Rect Rect::united(const Rect& other) const
  return rect;
 }
 
-Vector<Rect> Rect::shatter(const Rect& hammer) const
+Vector<Rect, 4> Rect::shatter(const Rect& hammer) const
 {
- Vector<Rect> pieces;
+ Vector<Rect, 4> pieces;
  if (!intersects(hammer)) {
- pieces.append(*this);
+ pieces.unchecked_append(*this);
  return pieces;
  }
  Rect top_shard {
@@ -66,13 +66,13 @@ Vector<Rect> Rect::shatter(const Rect& hammer) const
  min((hammer.y() + hammer.height()), (y() + height())) - max(hammer.y(), y())
  };
  if (intersects(top_shard))
- pieces.append(top_shard);
+ pieces.unchecked_append(top_shard);
  if (intersects(bottom_shard))
- pieces.append(bottom_shard);
+ pieces.unchecked_append(bottom_shard);
  if (intersects(left_shard))
- pieces.append(left_shard);
+ pieces.unchecked_append(left_shard);
  if (intersects(right_shard))
- pieces.append(right_shard);
+ pieces.unchecked_append(right_shard);
 
  return pieces;
 }

diff --git a/SharedGraphics/Rect.h b/SharedGraphics/Rect.h
@@ -177,7 +177,7 @@ class Rect {
  Point location() const { return m_location; }
  Size size() const { return m_size; }
 
- Vector<Rect> shatter(const Rect& hammer) const;
+ Vector<Rect, 4> shatter(const Rect& hammer) const;
 
  operator WSAPI_Rect() const;