Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dart analysis_server command #4761

Merged
merged 4 commits into from
May 9, 2024

Conversation

macuyler
Copy link
Contributor

In 2021 the dart team added a new sub-command language-server to replace the original ./snapshots/analysis_server.dart.snapshot --lsp convention for starting the language server.

The original convention does not work with the latest versions of dart.

In 2021 the dart team added a new sub-command `language-server` to
replace the original `./snapshots/analysis_server.dart.snapshot --lsp`
convention for starting the language server.

dart-lang/sdk@c224cc2
@w0rp
Copy link
Member

w0rp commented Apr 20, 2024

Can we add an option to switch the command back to the old version for those who need to keep using it? Changing right away is a little bit of a breaking change, but it's been unstable so I'm okay with an option to change it back and using the stable command right away.

@macuyler
Copy link
Contributor Author

macuyler commented May 7, 2024

@w0rp I added the option to switch back to the old version. Let me know if there is anything else I can do to help!

Include the dart version number where the `dart language-server` command
was added.
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@hsanson hsanson merged commit c88bddf into dense-analysis:master May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants