Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file mapping to phpstan #4685

Merged

Conversation

EdwinHuijsing
Copy link
Contributor

This should solve issue #4372 "phpstan filename mappings not respected when running via docker".

Vim 8 caused a problem in one test, because the error vim returns is not the same as the other three.

@EdwinHuijsing
Copy link
Contributor Author

I just rerun the docker test ./run-tests -q and no problems where reported.
"continuous-integration/appveyor/pr" runs on windows, looks like there is the cause of the test problem.
Will the patch work on windows? If the mapping is filled correct, i see no reason why it would give an problem

Any ideas who to fixes this? I can't test on windows (i don't have windows), so i am out of options.
I need a way to give the buffer a fixed full path, i have search before but i can't find way to give the buffer a fixed full path.

Regards,
Edwin

@EdwinHuijsing
Copy link
Contributor Author

Yesterday while working on an other linter, i found that we do not need the filename.
So i need to review the changes i did, locally i now have an version running that only
added two lines and changes one line.

More testing is needed before i can push the changes

Regards,
Edwin

We only needed to refactor the processing loop.
No extra test are needed.
@EdwinHuijsing EdwinHuijsing changed the title Add file mapping to php stan Add file mapping to phpstan Feb 2, 2024
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hsanson hsanson merged commit f38a802 into dense-analysis:master Feb 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants