Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed types on the ms function #3

Merged
merged 3 commits into from
May 22, 2020
Merged

Fixed types on the ms function #3

merged 3 commits into from
May 22, 2020

Conversation

JWebCoder
Copy link
Contributor

No description provided.

@kt3k
Copy link
Member

kt3k commented May 11, 2020

Thank you for updating!

Most part looks good to me. I think we should format the code with deno fmt command.

@rista404 rista404 mentioned this pull request May 11, 2020
Merged
@JWebCoder
Copy link
Contributor Author

Thank you for updating!

Most part looks good to me. I think we should format the code with deno fmt command.

Formated :)

kt3k
kt3k approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kt3k
Copy link
Member

kt3k commented May 11, 2020

@kevinkassimo
The current source code, especially the test cases, are so obsolete. I think we need to merge this change.

@JWebCoder
Copy link
Contributor Author

Hello, any updates on this? I would like to use this in another module. Thank you.

@TooTallNate
Copy link

Confirmed these changes fix the TypeScript compilation issues. Please merge 😃

kevinkassimo
kevinkassimo approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@kevinkassimo kevinkassimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinkassimo kevinkassimo merged commit dee7e83 into denolib:master May 22, 2020
@JWebCoder JWebCoder deleted the bugfix/fixes-typescript-types branch May 22, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@kevinkassimo kevinkassimo kevinkassimo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JWebCoder @kt3k @TooTallNate @kevinkassimo