Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Symbol only works in open files #811

Closed
mhanuszh opened this issue Feb 14, 2023 · 3 comments · Fixed by denoland/deno#17979
Closed

Rename Symbol only works in open files #811

mhanuszh opened this issue Feb 14, 2023 · 3 comments · Fixed by denoland/deno#17979

Comments

@mhanuszh
Copy link

Describe the bug

Rename Symbol only works in open files

To Reproduce

  1. Create two files, one exporting a value and another imporing it
  2. Close the file that imports
  3. Use the "Rename Symbol" command on the exported symbol

Expected behavior

All symbols in all files should be replaced with the new value, just as they do in "vanilla" typescript (when deno is disabled)

Versions

code --version

1.75.1
441438abd1ac652551dbe4d408dfcec8a499b8bf
x64

code --list-extensions --show-versions | grep deno

[email protected]

deno --version

deno 1.30.3 (release, x86_64-unknown-linux-gnu)
v8 10.9.194.5
typescript 4.9.4

@bartlomieju
Copy link
Member

This is the same cause as denoland/deno#11190

@mhanuszh
Copy link
Author

This is the same cause as denoland/deno#11190

@bartlomieju
Thanks for the information. Should this issue be closed as duplicate?

@bartlomieju
Copy link
Member

Let's keep it open so we can test when implementing the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants