Skip to content

Commit

Permalink
chore: rename "deno/task" request to "deno.taskDefinitions" (#1057)
Browse files Browse the repository at this point in the history
  • Loading branch information
nayeemrmn committed Jan 31, 2024
1 parent 9261c96 commit 53f08b3
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 16 deletions.
17 changes: 9 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -221,14 +221,15 @@ extension has the following configuration options:

## Compatibility

To see which versions of the Deno CLI are compatible with which versions of this
extension, consult the following table.

| vscode-deno | Deno CLI |
| --------------- | -------------- |
| 3.32.0 onwards | 1.37.1 onwards |
| 3.28.0 - 3.31.0 | 1.37.0 onwards |
| ? - 3.27.0 | ? - 1.36.4 |
To see which versions of this extension can be used with each version of the
Deno CLI, consult the following table.

| Deno CLI | vscode-deno |
| -------------- | --------------- |
| 1.37.2 onwards | TODO onwards |
| 1.37.1 | 3.32.0 - 3.33.3 |
| 1.37.0 | 3.28.0 - 3.31.0 |
| ? - 1.36.4 | 3.27.0 |

Version ranges are inclusive. Incompatibilites prior to 3.27.0 were not tracked.

Expand Down
2 changes: 1 addition & 1 deletion client/src/lsp_extensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const task = new RequestType0<
TaskRequestResponse[] | undefined,
void
>(
"deno/task",
"deno/taskDefinitions",
);

export interface TestData {
Expand Down
5 changes: 0 additions & 5 deletions client/src/tasks_sidebar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,6 @@ class DenoTaskProvider implements TaskProvider {
try {
const configTasks = await client.sendRequest(taskReq);
for (const { name, detail: command, sourceUri } of configTasks ?? []) {
// TODO(nayeemrmn): Deno LSP versions < 1.37.2 doesn't provide the
// `sourceUri`. Remove this eventually.
if (!sourceUri) {
continue;
}
const workspaceFolder = (workspace.workspaceFolders ?? []).find((f) =>
// NOTE: skipEncoding in Uri.toString(), read more at https://github.com/microsoft/vscode/commit/65cb3397673b922c1b6759d145a3a183feb3ee5d
sourceUri
Expand Down
4 changes: 2 additions & 2 deletions client/src/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ export interface TsApi {
}

interface DenoExperimental {
/** Support for the `deno/task` request, which returns any tasks that are
* defined in configuration files. */
/** Support for the `deno/taskDefinitions` request, which returns any tasks
* that are defined in configuration files. */
denoConfigTasks?: boolean;
}

Expand Down

0 comments on commit 53f08b3

Please sign in to comment.