Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove ESLint directives #941

Merged
merged 3 commits into from
May 30, 2021
Merged

chore: remove ESLint directives #941

merged 3 commits into from
May 30, 2021

Conversation

magurotuna
Copy link
Member

deno_lint doesn't support ESLint directives since denoland/deno#8226, so we can remove them.

ref: denoland/deno#10652

kitsonk
kitsonk approved these changes May 29, 2021
View reviewed changes
Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magurotuna magurotuna mentioned this pull request May 29, 2021
Merged
@magurotuna
Copy link
Member Author

Maybe blocked by #938

kt3k
kt3k approved these changes May 30, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magurotuna Thanks!

@kt3k kt3k merged commit 81be5fa into denoland:main May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk kitsonk approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magurotuna @kt3k @kitsonk