Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(datetime): make README consistent in format #933

Merged
merged 1 commit into from
May 24, 2021

Conversation

magurotuna
Copy link
Member

The README of datetime module has inconsistent format, like:

  • single quotations and double quotations are mixed
  • semicolon styles and non-semicolon styles are mixed
  • in some code blocks, not ts but js is specified as a language. Moreover, some code blocks don't have a language specified, so they are not syntax highlighted

This PR fixes all of the above.

@magurotuna magurotuna changed the title doc(datetime): make README consistent in format docs(datetime): make README consistent in format May 24, 2021
@magurotuna
Copy link
Member Author

No idea why CI failed... 🤷

@caspervonb

This comment has been minimized.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magurotuna Thanks for the fix! LGTM

@kt3k
Copy link
Member

kt3k commented May 24, 2021

Note: Reran CI and it passed. We'll do something if the flakiness persists.

@kt3k kt3k merged commit 4413ea7 into denoland:main May 24, 2021
@magurotuna magurotuna deleted the datetime-readme branch May 25, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants