Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): remove State class #5275

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

timreichen
Copy link
Contributor

  • removes State and inlines schema property into LoaderState and DumperState

@timreichen timreichen requested a review from kt3k as a code owner July 3, 2024 07:10
@github-actions github-actions bot added the yaml label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (b775a95) to head (8bc7653).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5275      +/-   ##
==========================================
- Coverage   95.70%   95.70%   -0.01%     
==========================================
  Files         459      458       -1     
  Lines       38025    38016       -9     
  Branches     5563     5563              
==========================================
- Hits        36393    36384       -9     
  Misses       1591     1591              
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 769cc02 into denoland:main Jul 3, 2024
15 checks passed
@timreichen timreichen deleted the yaml-remove-state branch July 3, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants