fix(testing): correctly throw in constructor with spy()
#5139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5139 +/- ##
==========================================
+ Coverage 93.02% 93.03% +0.01%
==========================================
Files 473 473
Lines 38061 38062 +1
Branches 5406 5407 +1
==========================================
+ Hits 35405 35411 +6
+ Misses 2605 2600 -5
Partials 51 51 ☔ View full report in Codecov by Sentry. |
iuioiua
changed the title
spy()
iuioiua
reviewed
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently thrown error from constructor is not captured by
spy. This PR enables spying thrown errors from constructor.