linter: add max-len rules #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I prefer strict 80 |
ry
reviewed
Jun 18, 2019
.eslintrc.json
Outdated
| { | ||
| "code": 80, | ||
| "tabWidth": 2, | ||
| "comments": 200, |
There was a problem hiding this comment.
200 columns for comments? that’s not ok.
There was a problem hiding this comment.
It just an example.
so, all strict to 80. including comments?
There was a problem hiding this comment.
There is some open source license that is significantly more than 80 characters.
This will modify these license to fix the error.
that's not cool.
There was a problem hiding this comment.
Yes, including comments (and licenses).
It seems you have a very wide monitor, but I program exclusively on a 12 inch laptop. So here is how it looks on my machine (full screen terminal):
|
Thanks for doing this! |
|
/cc @ry it's ready for review. Currently, only the length of the URL is ignored. {
"code": 80,
"tabWidth": 2,
"comments": 80,
"ignoreTrailingComments": false,
"ignoreUrls": true,
"ignoreStrings": false,
"ignoreTemplateLiterals": false,
"ignoreRegExpLiterals": false
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If strict execution of each line has a maximum width of 80 characters
Then there will be a lot of code getting ugly.
There are 3 lines below, which are
80/100/120characters.We can set the options to ignore comments/string and so on.
Just wrap code lines at 80 characters.