Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: re-write contributing guide #3748

Merged
merged 9 commits into from
Nov 11, 2023
Merged

docs: re-write contributing guide #3748

merged 9 commits into from
Nov 11, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Oct 30, 2023

I think this is all that's needed. Design and philosophy will come in another PR.

@iuioiua iuioiua requested a review from kt3k as a code owner October 30, 2023 01:07
@iuioiua iuioiua changed the title docs: rewrite contributing guide docs: re-write contributing guide Oct 30, 2023
@iuioiua iuioiua marked this pull request as draft October 30, 2023 01:30
@iuioiua iuioiua marked this pull request as ready for review October 31, 2023 11:07
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
iuioiua and others added 2 commits November 6, 2023 21:35
Co-authored-by: Yoshiya Hinosawa <[email protected]>
@iuioiua iuioiua requested a review from kt3k November 6, 2023 21:04
README.md Outdated
Comment on lines 124 to 126
While versioned independently of the Deno CLI, new minor versions of the
Standard Library and the Deno CLI are published at the same time (every 6
weeks). Patch versions may be published in between.
Copy link
Member

@kt3k kt3k Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look correct to me (std always releases new minor versions even when CLI does patch releases), or do you suggest we should change the release pattern of deno_std?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my misunderstanding. I didn't know this was the case. Either way, I thought this pattern didn't deviate too much from the current pattern. I'm not strongly opinionated, either way. My goal was to establish a predictable schedule while allowing us to move fast.

@iuioiua iuioiua requested a review from kt3k November 10, 2023 00:08
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 6585d77 into main Nov 11, 2023
12 checks passed
@iuioiua iuioiua deleted the contributing-rewrite branch November 11, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants