Remove parseFile from toml #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
39d6464
to
ff1dd84
Compare
ry
reviewed
Apr 25, 2019
toml/parser.ts
Outdated
| } | ||
| const strFile = await readFileStr(filePath); | ||
| return parse(strFile); | ||
| } |
There was a problem hiding this comment.
Actually I'd rather that we remove the parseFileSync and leave it up to the caller to load the data. The TOML module should only deal with parsing, not with I/O.
Would you mind a revised PR that removes parseFileSync (or just moves it to the test module - if that is needed there)?
There was a problem hiding this comment.
That makes a lot of sense to me!
ry
reviewed
Apr 25, 2019
| } else { | ||
| inLitteral = true; | ||
| inLiteral = true; |
ff1dd84
to
8b5fe1a
Compare
6d21401
to
883f09c
Compare
883f09c
to
4619669
Compare
zekth
suggested changes
Apr 25, 2019
|
Done
From: Vincent LE GOFF
Sent: Thursday, April 25, 2019 3:26 PM
To: denoland/deno_std
Cc: Jimmy Cao; Author
Subject: Re: [denoland/deno_std] Remove parseFile from toml (#361)
@zekth requested changes on this pull request.
As parseFile has been deleted, please update the README.md
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
ry
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to close if this is not the right direction