Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(fmt): rename stripColor to stripAnsiCode #3588

Merged
merged 2 commits into from
Aug 31, 2023
Merged

BREAKING(fmt): rename stripColor to stripAnsiCode #3588

merged 2 commits into from
Aug 31, 2023

Conversation

lino-levan
Copy link
Contributor

Closes #3580

@lino-levan lino-levan requested a review from kt3k as a code owner August 30, 2023 20:10
@github-actions github-actions bot added the fmt label Aug 30, 2023
iuioiua
iuioiua requested changes Aug 30, 2023
View reviewed changes
fmt/colors.ts Outdated Show resolved Hide resolved
@lino-levan @iuioiua
Update colors.ts
a49b391 
Co-authored-by: Asher Gomez <[email protected]>
@lino-levan
Copy link
Contributor Author

Another flaky test failure it appears

kt3k
kt3k approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@kt3k kt3k merged commit eaaabe4 into denoland:main Aug 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
fmt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename stripColor to stripAnsi
3 participants
@lino-levan @kt3k @iuioiua