-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(async): add jitter to retry exponential backoff #3379
Conversation
I'm pretty strongly -1 against complicating the API to allow for arbitrary backoff functions. When I made the PR to introduce TLDR; I think adding an option for jitter would be fine, but please don't overcomplicate the API with backoff functions. |
I never thought about making jitter enabled by default but honestly that makes sense (plus it removes an option which is always nice). Thoughts @iuioiua? |
Ah I thought that was what you meant, but re-reading your post I see I misunderstood. Pros of always using jitter:
Pros of having an option for jitter, disabled by default:
Pros of having an option for jitter, enabled by default:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice!
Fixes #3378