Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove second call to runTests #328

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Remove second call to runTests #328

merged 1 commit into from
Apr 9, 2019

Conversation

bartlomieju
Copy link
Member

@bartlomieju
Copy link
Member Author

CC @zekth if this is intended, then it's better you rewrite test.ts in root dir to call runTests twice rather than doing it in testing/main.ts. Your opinion?

ry
ry approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 2c11962 into denoland:master Apr 9, 2019
@zekth
Copy link
Contributor

zekth commented Apr 9, 2019

it was the patch of @chiefbiiko , i've just changed the exitonfail parameter, which revealed the non tested case of the parallel execution. Maybe this part needs a little refactor.

@bartlomieju bartlomieju deleted the patch-1 branch April 9, 2019 08:44
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@bartlomieju @ry
Fix denoland/denodenoland/deno_std#2064 (denoland/std#328)
733fbfd 
Original: denoland/std@2c11962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartlomieju @zekth @ry