Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(node/path): Enable test-path-dirname.js #1897

Merged
merged 1 commit into from
Feb 10, 2022
Merged

test(node/path): Enable test-path-dirname.js #1897

merged 1 commit into from
Feb 10, 2022

Conversation

wafuwafu13
Copy link
Contributor

No description provided.

kt3k
kt3k approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wafuwafu13 LGTM. Thanks!

node/_tools/suites/parallel/test-path-dirname.js
// deno_std: path/to/deno_std/node/_tools/suites/parallel

// assert.strictEqual(path.dirname(__filename).substr(-13),
// common.isWindows ? 'test\\parallel' : 'test/parallel');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm ok let's skip this assertion

@kt3k kt3k merged commit 184b733 into denoland:main Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wafuwafu13 @kt3k