Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): fix fs.copyFile (support 4-arg call) #1872

Merged
merged 4 commits into from
Feb 3, 2022
Merged

fix(node): fix fs.copyFile (support 4-arg call) #1872

merged 4 commits into from
Feb 3, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 2, 2022

closes #1860

part of yarn blocker issues denoland/deno#13420

bartlomieju
bartlomieju approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to see more Node tests being enabled

@kt3k kt3k merged commit 463dca3 into denoland:main Feb 3, 2022
@kt3k kt3k deleted the fix/node-fs-copy-file branch February 3, 2022 00:52
@kt3k kt3k self-assigned this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees

@kt3k kt3k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node: fs.copyFile doesn't support 4 args overload
2 participants
@kt3k @bartlomieju