-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updates related to TypeScript 4.4 #1171
Conversation
TypeScript changes look good to me. The CI failure looks very strange to me.
It looks like something triggered rustup command and cargo fmt somehow? |
…nly once at the beginning (denoland#1143) Co-authored-by: evanwashere <[email protected]>
And therefore the test command executes |
We should probably just exclude that file from testing |
Ok. I'll update with appropriate |
Should be scanned for documentation tests but the module should not imported.
Would gate executable scripts with |
@kt3k I rebased and merged your commit... the commit history is a bit odd now in this PR, but hopefully CI passes. |
Hmmm... nope... still doing strange things. |
@kitsonk |
Ok, I just need someone to approve it! 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR does the following:
std
to make it compatible with TypeScript 4.4 as configured in Deno CLI.@ts-ignore
to@ts-expect-error
as that is better, as several errors are now "fixed" under TS 4.4"useUnknownInCatchVariables"
which is shipping as disabled in Deno CLI 1.14 but hopefully will be enabled for 1.15.There was also a change in how Deno canary checks files for test and caught some errors in modules that weren't covered by tests.
Because of the improvements to TypeScript 4.4 and the ignored errors that are no longer ignored, the next release of
std
will not be compatible with Deno prior to 1.14.