Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os util on entire of codebase #1123

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Use os util on entire of codebase #1123

merged 2 commits into from
Aug 13, 2021

Conversation

behnammodi
Copy link
Contributor

we had os util but in some where of code we didn't use it

@CLAassistant
Copy link

CLAassistant commented Aug 11, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@behnammodi behnammodi force-pushed the use-os-util branch 2 times, most recently from 5ce5bdd to 6f043f2 Compare August 11, 2021 19:22
kitsonk
kitsonk reviewed Aug 11, 2021
View reviewed changes
_util/os.ts Outdated Show resolved Hide resolved
kt3k
kt3k approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 1a34641 into denoland:main Aug 13, 2021
@bartlomieju
Copy link
Member

Can I join as a member in denoland? :)

Sorry, that's not possible, only employees of Denoland have "member" access.

@behnammodi behnammodi deleted the use-os-util branch December 16, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@kitsonk kitsonk Awaiting requested review from kitsonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@behnammodi @CLAassistant @bartlomieju @kt3k @kitsonk