Rolling to V8 10.0.139.6 #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lucacasonato
reviewed
Mar 8, 2022
Comment on lines
236
to
249
| /// Clears all references to the v8::Platform. This should be invoked after | ||
| /// V8 was disposed. | ||
| pub fn shutdown_platform() { | ||
| /// V8 was disposed. If it is called if V8 is not disposed, it will panic. | ||
| pub fn dispose_platform() { | ||
| let mut global_state_guard = GLOBAL_STATE.lock().unwrap(); | ||
| // First shutdown platform, then drop platform | ||
| unsafe { v8__V8__ShutdownPlatform() }; | ||
| // First check that the global state is disposed. If it is we dispose the | ||
| // platform. We then drop the platform. | ||
| *global_state_guard = match *global_state_guard { | ||
| Disposed(_) => PlatformShutdown, | ||
| Disposed(_) => { | ||
| unsafe { v8__V8__DisposePlatform() }; | ||
| PlatformShutdown | ||
| } | ||
| _ => panic!("Invalid global state"), | ||
| }; | ||
| } |
There was a problem hiding this comment.
Please pay extra attention to this change. I updated the order of operations to be more correct. Previously we'd dispose the platform before checking if it is ready to be disposed. Now we check the global state before attempting disposal.
There was a problem hiding this comment.
Makes sense, though it appears that v8 already tracks a similar state-machine internally.
Do we wrap this only so we can throw rust-side panics rather than v8's FATAL ?
There was a problem hiding this comment.
I think so. @piscisaureus or @ry would have to confirm.
AaronO
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
V8::shutdown_platform()->V8::dispose_platform()v8::HostImportModuleDynamicallyCallbackhas new argumentsv8::Global::get()has been removed. Usev8::Global::open()v8::script_compiler::compile_function_in_context->v8::script_compiler::compile_function