Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v8::Object::HasOwnProperty bindings #897

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Add v8::Object::HasOwnProperty bindings #897

merged 4 commits into from
Feb 11, 2022

Conversation

littledivy
Copy link
Member

No description provided.

@littledivy
Copy link
Member Author

Needed for denoland/deno#13633

@littledivy littledivy mentioned this pull request Feb 11, 2022
Merged
@littledivy littledivy changed the title Add V8::Object::HasOwnProperty bindings Add v8::Object::HasOwnProperty bindings Feb 11, 2022
piscisaureus
piscisaureus reviewed Feb 11, 2022
View reviewed changes
src/binding.cc Outdated Show resolved Hide resolved
piscisaureus
piscisaureus reviewed Feb 11, 2022
View reviewed changes
src/binding.cc Outdated Show resolved Hide resolved
piscisaureus
piscisaureus reviewed Feb 11, 2022
View reviewed changes
src/object.rs Outdated Show resolved Hide resolved
piscisaureus
piscisaureus reviewed Feb 11, 2022
View reviewed changes
tests/test_api.rs Outdated Show resolved Hide resolved
@piscisaureus
Copy link
Member

piscisaureus commented Feb 11, 2022 •
edited
Loading

LGTM when the clippy warnings are addressed.

@littledivy littledivy merged commit 378631e into denoland:main Feb 11, 2022
@littledivy littledivy deleted the has_own_property branch February 11, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@littledivy @piscisaureus