Add v8::Value::InstanceOf bindings #879
Conversation
|
I am not in favor of implementing deref_mut for Local handles. |
src/handle.rs
Outdated
| impl<'s, T> DerefMut for Local<'s, T> { | ||
| fn deref_mut(&mut self) -> &mut T { | ||
| unsafe { self.0.as_mut() } | ||
| } | ||
| } |
There was a problem hiding this comment.
As per @piscisaureus's comment we should remove this
There was a problem hiding this comment.
instance_of requires for T to be mutable in v8::Local<T>, hence the deref_mut implementation. I'm not sure how you can do instance_of on a local handle without this.
There was a problem hiding this comment.
Is there a reason the InstanceOf function is not marked as const in the c++ api?
Seems counter-intuitive, could this be a mistake in the v8 c++ api?
There was a problem hiding this comment.
There was a problem hiding this comment.
@piscisaureus please advise
|
I may well be wrong, but it seems like this binding will be necessary for implementing magic (de)serialiser for FFI-related custom class wrapping ArrayBuffers for passing to native libraries. |
|
Discussed offline with @littledivy.
|
No description provided.