Rolling to V8 9.7.106.2 #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, was super trivial. False alarm. |
Merged
lucacasonato
reviewed
Nov 7, 2021
src/binding.cc
Outdated
Comment on lines
974
to
976
| const v8::Value* v8__Symbol__Description(v8::Isolate* isolate, | ||
| const v8::Symbol& self) { | ||
| return local_to_ptr(ptr_to_local(&self)->Description(isolate)); |
There was a problem hiding this comment.
|
Actually not as simple as it looks (all new code for me). Tests don't pass locally now :/ |
9a0f889
to
edbe367
Compare
Nvm, by local build was just broken. Wiped my target dir and rebuilt, and now it is all working fine :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.