Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Handle::get() to Handle::open() instead #806

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Rename Handle::get() to Handle::open() instead #806

merged 1 commit into from
Oct 13, 2021

Conversation

piscisaureus
Copy link
Member

This also adds a deprecated Global::get() method to avoid unnecessarily breaking a lot of users code.

cc @espindola

@piscisaureus
Rename Handle::get() to Handle::open() instead
63a2363 
This also adds a deprecated `Global::get()` method to avoid unnecessarily
breaking a lot of users code.

Ref: #799
bartlomieju
bartlomieju approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piscisaureus piscisaureus merged commit d478c45 into main Oct 13, 2021
@piscisaureus piscisaureus deleted the handle_open branch October 13, 2021 19:45
@piscisaureus piscisaureus mentioned this pull request Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piscisaureus @bartlomieju