Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include ICU file in crate #722

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Include ICU file in crate #722

merged 2 commits into from
Jul 2, 2021

Conversation

ry
Copy link
Member

@ry ry commented Jul 1, 2021 •
edited
Loading

Fixes #721

# ls -lh target/package/rusty_v8-0.24.0.crate
-rw-r--r--  1 ry  staff    14M Jul  1 17:06 target/package/rusty_v8-0.24.0.crate

This was the only workaround I could find. Should still fit under the 20M limit for crates.io

We should also add a CI job that tests "cargo package".

@piscisaureus piscisaureus merged commit 1e533a1 into main Jul 2, 2021
@piscisaureus piscisaureus deleted the fix-cargo-package branch May 18, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo publish fails
3 participants
@ry @bnoordhuis @piscisaureus